[SYCL][UR][L0 v2] import host ptr when SYCL_USM_HOSTPTR_IMPORT=1 and fix mapHostPtr #19297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches v1 functionality and speeds up subsequent buffer map/unmap operations by making memory copy faster.
The logic for freeing mappedPtr was incorrect. We should only free the memory in unmapHostPtr if the pointer was allocated in mapHostPtr, not the other way around.
pbalcer
reviewed
Jul 4, 2025
| ur_integrated_buffer_handle_t(ur_context_handle_t hContext, void *hostPtr, | ||
| size_t size, host_ptr_action_t useHostPtr, | ||
| device_access_mode_t accesMode); | ||
| size_t size, device_access_mode_t accesMode); | ||
|
|
||
| ur_integrated_buffer_handle_t(ur_context_handle_t hContext, void *hostPtr, | ||
| size_t size, device_access_mode_t accesMode, |
There was a problem hiding this comment.
Suggested change
| size_t size, device_access_mode_t accesMode, | |
| size_t size, device_access_mode_t accessMode, |
(I know, unrelated to this PR :P)
Fixed. It seems that UR_MEM_FLAG_USE_HOST_POINTER does not have to be set when hostPtr is not null. In the legacy adapter this flag controlled whether to import the memory to USM or not but I don't see a reason not to do it in all cases. It seems that SYCL almost always sets UR_MEM_FLAG_USE_HOST_POINTER anyway (except in that one test) |
|
Actually, I wonder why do we event support that combination (non-null hostPtr and no USE_HOST_PTR flag). OpenCL doesn't seem to allow this: https://registry.khronos.org/OpenCL/sdk/3.0/docs/man/html/clCreateBuffer.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.